Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method-hints from Faker\Generator to the Facade #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonberger
Copy link

@simonberger simonberger commented Apr 25, 2024

I wanted to somehow fix the non resolving method calls from the facade since a longer time.
While Faker itself also has no true methods in its Generator, they solve it with @property and @method annotations which works well enough.
I first tried to somehow "inherit" the methods from the faker generator to the facade but that would never work in all IDEs and static analyzers and is probably impossible because of the static <-> non static difference.

What I did was getting the method and property annotation block from Faker\Generator and process the following 4 steps on it:

  1. Copy the whole property + method annotation block
  2. Replace @method with @method static
  3. Remove all @property and empty lines
  4. Align method names

@simonberger
Copy link
Author

@GrahamCampbell sorry for mentioning, but I doubt this project is really checked.
It would be great this fix could make it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant