Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonMark spec 0.31 compatibility #1011

Open
wants to merge 6 commits into
base: 2.4
Choose a base branch
from
Open

Conversation

colinodell
Copy link
Member

This PR brings our library into compliance with the latest version (0.31) of the CommonMark spec.

@colinodell colinodell added spec compliance Issues or question about compliance with the CommonMark or GFM specs do not close Issue which won't close due to inactivity labels Feb 2, 2024
@colinodell colinodell self-assigned this Feb 2, 2024
We fix issues with list tightness by using a different strategy:

1. Compare the end and start lines of adjoining elements
   to check tightness. (This required tweaking the end
   position of some block types to exclude trailing blank
   lines.)

2. Delay removal of link reference definitions until the
   entire document is parsed.

See commonmark/commonmark.js@df3ea1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not close Issue which won't close due to inactivity spec compliance Issues or question about compliance with the CommonMark or GFM specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant