fix #173 by using importlib-resources < 6.0 #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulWAyers
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Seems fine to me but I'm going to defer to @Ali-Tehrani for merging.
Ali-Tehrani
added a commit
to Ali-Tehrani/grid
that referenced
this pull request
Aug 3, 2023
This arises from pull-request theochem#174. Rather than using an older version of import-resources. This fixed the issue to the current API
|
Thank you @yingxingcheng for bringing up this issue and providing a solution. I update the code to the current API in #176 and will be closing this. |
Ali-Tehrani
added a commit
that referenced
this pull request
Aug 3, 2023
* Update clenshaw in website table * Fix #173 by updating import-resources API This arises from pull-request #174. Rather than using an older version of import-resources. This fixed the issue to the current API * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #173