Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes the pin button showing when it shouldn't be #620

Open
wants to merge 2 commits into
base: frost
Choose a base branch
from
Open

fixes the pin button showing when it shouldn't be #620

wants to merge 2 commits into from

Conversation

justcool393
Copy link
Collaborator

specifically when Comment.sticky_api_url returns None. None is not "", so it shows the button, albeit with a bad url

@justcool393
fixes the pin button showing when it shouldn't be
1dc767e 
specifically when `Comment.sticky_api_url` returns None. None is not
`""`, so it shows the button, albeit with a bad url
@justcool393 justcool393 added the bug Something isn't working label Jul 12, 2023
@justcool393 justcool393 self-assigned this Jul 12, 2023
TLSM
TLSM requested changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@TLSM TLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed change to the desktop template works as intended!

See files/templates/component/comment/actions_mobile_admin.html, though, which probably needs a similar conditional (and conversion to use Comment.sticky_api_url).

@justcool393
Copy link
Collaborator Author

The proposed change to the desktop template works as intended!

See files/templates/component/comment/actions_mobile_admin.html, though, which probably needs a similar conditional (and conversion to use Comment.sticky_api_url).

horrifyingly, it seems like they're split across two files, so not sure how to best rectify that (actions_mobile_admin.html and actions_mobile.html)

@justcool393 justcool393 requested a review from TLSM July 28, 2023 05:31
@justcool393
Copy link
Collaborator Author

The proposed change to the desktop template works as intended!

See files/templates/component/comment/actions_mobile_admin.html, though, which probably needs a similar conditional (and conversion to use Comment.sticky_api_url).

reviewed and changed. we test for sticky_api_url here. because they're in different modals, it's hard to unify them, but we can at least do a test.

@zorbathut
Copy link
Contributor

Whoops, this ended up with conflicts. Sorry, lotta stuff going through lately >_<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TLSM TLSM Awaiting requested review from TLSM

Requested changes must be addressed to merge this pull request.

Assignees

@justcool393 justcool393

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justcool393 @zorbathut @TLSM