Integrate chat from upstream #611
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Substantially borrowed from upstream ref: 13a208ee88e55 (before they
started editing generated artefacts instead of source).
Integrated, including:
- Remove previously removed features: emoji, hats, and name colors
- Compensate for lack of unified root template
- Add React build process to Dockerfile and `bootstrap/init.sh`
- Preliminary integration of chat websocket workers
For testing, modify `supervisord.conf.dev` to put chat on port 80 and
the site service on some other port. Then visit: http://localhost/chat
Still to do:
- Access control for specific small-groups (and admins probably):
Set the values somewhere (site_settings.json? Redis?) and use for
authorization in `chat_is_allowed`.
- Proxying only /chat to the websocket workers
- Chat persistance across restarts: either Redis devops or to DB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantially borrowed from upstream ref: 13a208ee88e55 (before they started editing generated artefacts instead of source).
Integrated, including:
bootstrap/init.shFor testing, modify
supervisord.conf.devto put chat on port 80 and the site service on some other port. Then visit: http://localhost/chatStill to do:
chat_is_allowed.