Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack 4 #2117

Merged
merged 4 commits into from Apr 6, 2018
Merged

Upgrade to webpack 4 #2117

merged 4 commits into from Apr 6, 2018

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Feb 25, 2018

@xPaw xPaw added the Meta: Do Not Merge This PR should not be merged. label Feb 25, 2018
@xPaw xPaw force-pushed the webpack4 branch 2 times, most recently from 9ff113e to ad011b9 Compare February 25, 2018 17:48
@astorije astorije added the Meta: Internal This is an internal codebase change (testing, linting, etc.). label Feb 25, 2018
@astorije astorije added this to the 3.0.0 milestone Feb 25, 2018
@astorije
Copy link
Member

A bunch of PRs in related projects are opened, I am now subscribed to all of them I believe, so I'll post here when I get notified.
Now let's see what projects come through.

Ah, the joys of major upgrades in the Webpack world...

@astorije
Copy link
Member

yarn test:browser produces nothing, not sure why :/

@astorije
Copy link
Member

@xPaw, you mentioned yarn test:browser works for you. Mine doesn't, super weird. Could you confirm you do not see this on your end:

screen shot 2018-03-21 at 20 15 28

@MaxLeiter
Copy link
Member

@astorije: can confirm same issue on macOS

@xPaw
Copy link
Member Author

xPaw commented Mar 22, 2018

@astorije Yeah, it's empty for me too now...

@xPaw
Copy link
Member Author

xPaw commented Apr 5, 2018

I think this is ready expect for the test:browser being busted.

@astorije
Copy link
Member

astorije commented Apr 6, 2018

I was pretty much giving up, ended up spending way too much time on this, but it turns out a simple * fixed test:browser. Be damned, Webpack.

@astorije astorije removed the Meta: Do Not Merge This PR should not be merged. label Apr 6, 2018
@xPaw xPaw merged commit 6626fbc into master Apr 6, 2018
@xPaw xPaw deleted the webpack4 branch April 6, 2018 09:59
@xPaw xPaw changed the title Upgrade to webpack 4; tracking pr Upgrade to webpack 4 Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta: Internal This is an internal codebase change (testing, linting, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants