Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update urijs to the latest version 馃殌 #1604

Merged
merged 2 commits into from Oct 6, 2017
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Oct 1, 2017

Version 1.19.0 of urijs just got published.

Dependency urijs
Current Version 1.18.12
Type dependency

The version 1.19.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of urijs.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 4 commits.

  • fde82ec chore(build): bumping to version 1.19.0
  • 3cc5c22 chore(build): bumping to version 1.19.0
  • d1cedf2 fix(parse): add URI.preventInvalidHostname to make hostname validation optional - #345, 352, #354, #355
  • 29ab103 feature(fragment-query): add setFragment()

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 馃尨

@greenkeeper greenkeeper bot added the Type: Dependencies Automatic updates for dependencies, managed by Renovate. label Oct 1, 2017
@astorije
Copy link
Member

astorije commented Oct 1, 2017

@xPaw, since medialize/URI.js#352 got fixed in URI.js v1.19.0, can we now remove #1412 ? I really don't want to have catch-all mechanisms in our code :S

@xPaw
Copy link
Member

xPaw commented Oct 1, 2017

@astorije I guess we can remove it.

@xPaw xPaw added this to the 2.6.0 milestone Oct 1, 2017
@astorije
Copy link
Member

astorije commented Oct 2, 2017

@xPaw, done. Any test in particular you want me to add to make sure we catch this if it ever happens again?

@astorije astorije assigned astorije and unassigned xPaw Oct 5, 2017
@xPaw
Copy link
Member

xPaw commented Oct 5, 2017

Let's get this in 2.5 since it's possible to crash lounge:

23:24 <lounge-user79>  i've got problems with my docker container running lounge
23:24 <lounge-user79>  done a "docker attach" to the container which constantly restarts
23:24 <lounge-user79>        parts.password = t[0] ? URI.decode(t.join(':')) : null;
23:25 <lounge-user79>   /usr/local/lib/node_modules/thelounge/node_modules/urijs/src/URI.js:595
23:25 <lounge-user79>  URIError: URI malformed
23:25 <lounge-user79>  i have the slight feeling someone broke my instance by posting an invalid url or something xD

@xPaw xPaw modified the milestones: 2.6.0, 2.5.0 Oct 5, 2017
@astorije
Copy link
Member

astorije commented Oct 5, 2017

I'm leaving that up to @YaManicKill if he is okay to have this in 2.5.0 (in which case I'll release a rc.4 with that) or not. I'm fine either way, good catch!

@astorije astorije assigned AlMcKinlay and unassigned astorije Oct 5, 2017
@dgw
Copy link
Contributor

dgw commented Oct 6, 2017

@xPaw said above that this will close a crash vector, so hopefully it gets merged. :shipit:

@dgw dgw mentioned this pull request Oct 6, 2017
@xPaw xPaw merged commit 530d717 into master Oct 6, 2017
@xPaw xPaw deleted the greenkeeper/urijs-1.19.0 branch October 6, 2017 07:15
@AlMcKinlay
Copy link
Member

FWIW, I was happy with this.

@AlMcKinlay AlMcKinlay removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependencies Automatic updates for dependencies, managed by Renovate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants