New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update urijs to the latest version 馃殌 #1604
Conversation
@xPaw, since medialize/URI.js#352 got fixed in URI.js v1.19.0, can we now remove #1412 ? I really don't want to have catch-all mechanisms in our code :S |
@astorije I guess we can remove it. |
@xPaw, done. Any test in particular you want me to add to make sure we catch this if it ever happens again? |
Let's get this in 2.5 since it's possible to crash lounge:
|
07bcb4c
to
8f550c3
Compare
8f550c3
to
9a8c1b2
Compare
I'm leaving that up to @YaManicKill if he is okay to have this in 2.5.0 (in which case I'll release a rc.4 with that) or not. I'm fine either way, good catch! |
@xPaw said above that this will close a crash vector, so hopefully it gets merged. |
FWIW, I was happy with this. |
Version 1.19.0 of urijs just got published.
The version 1.19.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of urijs.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 4 commits.
fde82ec
chore(build): bumping to version 1.19.0
3cc5c22
chore(build): bumping to version 1.19.0
d1cedf2
fix(parse): add URI.preventInvalidHostname to make hostname validation optional - #345, 352, #354, #355
29ab103
feature(fragment-query): add setFragment()
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 馃尨