Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw an exception when URI parsing fails #1412

Merged
merged 1 commit into from Aug 15, 2017
Merged

Do not throw an exception when URI parsing fails #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions client/js/libs/handlebars/ircmessageparser/findLinks.js
View file
Open in desktop
Expand Up @@ -23,8 +23,16 @@ function findLinks(text) {
// See https://medialize.github.io/URI.js/docs.html#static-withinString
// In our case, we store each URI encountered in a result array.
URI.withinString(text, function(url, start, end) {
// Extract the scheme of the URL detected, if there is one
const parsedScheme = URI(url).scheme().toLowerCase();
let parsedScheme;

try {
// Extract the scheme of the URL detected, if there is one
parsedScheme = URI(url).scheme().toLowerCase();
} catch (e) {
// URI may throw an exception for malfored urls,
// as to why withinString finds these in the first place is a mystery
return;
}

// Check if the scheme of the detected URL matches a common one above.
// In a URL like `foo..http://example.com`, the scheme would be `foo..http`,
Expand Down