Upgrade cross-fetch and remove node-fetch

[minkimcello]

Motivation

To resolve #607

Approach

• Upgrade cross-fetch to 3.1.5
• Remove node-fetch
• Update @effection/process tests
• Added change file for a patch bump of @effection/fetch only as the changes for @effection/process in dev env only

[cowboyd]

Any reason this wasn't working the same as before?

[minkimcello]

It returns the Fetch interface and not the response without the yield

[cowboyd]

Ah, I see we're using the Effection fetch here. If we're going to treat the error as a value, then let's just capture it as a return value instead of re-assigning a variable.

let error = yield function*() {
  try {
    yield fetch(`http://localhost:29000`, { method: "POST", body: "hello" });
  } catch (error) {
    return error;
  }
}
expect(error).toMatchObject({ name: 'FetchError' });

This is more composable (decoupled from context) since it can be abstracted to handle any operation, not just a fetch.

function* capture<T>(operation: Operation<T>): Operation<Error | T> {
  try {
    return yield operation;
  } catch (error) {
    return error;
  }

Which we can then use as

expect(yield capture(fetch(`http://localhost:29000`, { method: "POST", body: "hello" }))).toMatchObject({ name: 'FetchError' });

In fact, I think there might be already a captureError operation in @effection/mocha

[minkimcello]

👍 cd7698e

[cowboyd]

Looks great!