Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foreman-tasks-core to 0.3.0 (deb-proxy) #3438

Closed

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Feb 8, 2019

For plugin updates, please indicate which repos this should be built into:

  • Nightly
  • 1.21
  • 1.20

See Foreman's plugin maintainer documentation for more information.


@iNecas iNecas changed the title Update foreman-tasks-core to 0.3.0 Update foreman-tasks-core to 0.3.0 (deb) Feb 8, 2019
@iNecas iNecas changed the title Update foreman-tasks-core to 0.3.0 (deb) Update foreman-tasks-core to 0.3.0 (deb-proxy) Feb 8, 2019
@iNecas iNecas force-pushed the deb/foreman-tasks-0.15.0-proxy branch from d15b621 to 5ab063e Compare February 8, 2019 11:21
@@ -11,7 +11,7 @@ XS-Ruby-Versions: all
Package: ruby-dynflow
Architecture: all
XB-Ruby-Versions: ${ruby:Versions}
Depends: ${shlibs:Depends}, ${misc:Depends}, ruby | ruby-interpreter, ruby-algebrick (>= 0.7.0), ruby-algebrick (<< 0.8.0), ruby-apipie-params, ruby-concurrent (>= 1.0.0), ruby-concurrent (<< 2.0.0), ruby-multi-json, ruby-sequel (>= 4.0.0)
Depends: ${shlibs:Depends}, ${misc:Depends}, ruby | ruby-interpreter, ruby-algebrick (>= 0.7.0), ruby-algebrick (<< 0.8.0), ruby-apipie-params, ruby-concurrent (>= 1.1.3), ruby-concurrent (<< 2.0.0), ruby-multi-json, ruby-sequel (>= 4.0.0)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmoll we updated dependency on concurrent-ruby in dynflow. There should be also bump on concurrent-ruby-edge ~> 0.4.1 but I don't see in anywhere.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because ruby-concurrent 1.0.x is coming from the distro repos and contains -edge in that package, also.

We need to DEB package ruby-concurrent 1.1 and -edge like we had it in the beginning.

I'll have a look if I can handle this in the current distro package and also submit this upstream, if possible.

@empereira
Copy link

hello,

Any news about ruby-concurrent 1.1.x version?

@mmoll
Copy link

mmoll commented May 15, 2019

It's ready when it's ready...

@empereira
Copy link

It's ready when it's ready...

@mmoll Sorry if it sounded like I'm rushing you! I know it's not an easy job! Excuse!

@mmoll
Copy link

mmoll commented May 15, 2019

@infomatico No problem, I should have done this long time ago and 1.22 is approaching quickly... The task itself not so hard, but telling if it really works without side-effects and handle the things when using native debian.org/ubuntu.com DEBs proved brittle in the past...

@mmoll
Copy link

mmoll commented May 18, 2019

I'm sorry, but I'm giving up on this. The newer versions of the concurrent-ruby-edge gem bring (also in the build gems) thier files not in a lib but in a lib-edge dir, which breaks the whole Debian gem tooling.

@iNecas Can you somehow influence the concurrent-ruby guys to release a new major version of concurrent that includes the stuff dynflow uses from current -edge?

@empereira
Copy link

I'm sorry, but I'm giving up on this. The newer versions of the concurrent-ruby-edge gem bring (also in the build gems) thier files not in a lib but in a lib-edge dir, which breaks the whole Debian gem tooling.

@iNecas Can you somehow influence the concurrent-ruby guys to release a new major version of concurrent that includes the stuff dynflow uses from current -edge?

Hey @iNecas and @mmoll, if I create an issue in concurrent-ruby git, would it help?

@iNecas
Copy link
Member Author

iNecas commented May 20, 2019

Let's see ruby-concurrency/concurrent-ruby#809

@empereira
Copy link

Let's see ruby-concurrency/concurrent-ruby#809

Cool!!! 👍

@empereira
Copy link

@iNecas any news about the problem with ruby-concurrency?

@iNecas
Copy link
Member Author

iNecas commented Jun 7, 2019

I've just checked with the maintainer: he's currently busy with other duties, but will try to get to it soonish: no promises though (which at least doesn't mean it will not happen :)

@pitr-ch
Copy link
Member

pitr-ch commented Jun 7, 2019

Hi, I am the maintainer of concurrent-ruby. Could you create a new issue there describing the problem with lid-edge. It might be faster to just fix the path in edge than moving actors into core.

@empereira
Copy link

Hi, I am the maintainer of concurrent-ruby. Could you create a new issue there describing the problem with lid-edge. It might be faster to just fix the path in edge than moving actors into core.

Hello!!

@pitr-ch thanks for your feedback!!! :D

@iNecas Were you able to create the new issue? :D

@iNecas
Copy link
Member Author

iNecas commented Jun 17, 2019

This needs someone that understands what the current issue with lib-edge is, and unfortunately, I'm not the one of them

@Kassec
Copy link

Kassec commented Jun 20, 2019

Hello,

Is there any workaround to this issue? I'm not a Ruby geek and have a hard time figuring how to get around properly ;)

@empereira
Copy link

Hello @iNecas @mmoll @pitr-ch

Any news about fixes?

@mmoll
Copy link

mmoll commented Aug 7, 2019

@infomatico there is no movement in the concurrent-ruby PR and there's nothing we can do on our side.

@empereira
Copy link

@infomatico there is no movement in the concurrent-ruby PR and there's nothing we can do on our side.

Ok @mmoll!! thanks for your feedback!!

@mmoll mmoll mentioned this pull request Aug 15, 2019
@ekohl
Copy link
Member

ekohl commented Jan 15, 2020

By now this has merge conflicts. AFAIK this is broken for quite some time. Would it be more honest to drop the packages so there's no expectation that it works?

@theforeman theforeman deleted a comment from empereira Jan 17, 2020
@mmoll
Copy link

mmoll commented Jan 17, 2020

upstream PR: ruby-concurrency/concurrent-ruby#812

@theforeman theforeman locked and limited conversation to collaborators Jan 17, 2020
@theforeman-bot
Copy link
Member

@iNecas, this pull request is currently not mergeable. Please rebase against the deb/develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream deb/develop

This message was auto-generated by Foreman's prprocessor

@mmoll mmoll closed this Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants