refactor: use the new twitter (X) logo #649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since twitter updated it's logo it makes sense to update it in the theme.
✅ Deploy Preview for gohugo-ananke-theme-demo canceled.
|
|
Thanks @Nr18 . This does not look right: |
|
Graphics is far from my expertise... You want it smaller or in a disk? The GitLab logo isn't in a disk either I noticed... |
True, it's not a perfect system, but it still integrates nicely with the other icons. I guess my reluctance to approve this outright is triggered by the size and color of your proposition.
Twitter/X is probably on 80% of Ananke sites, so I want to tread lightly. Thanks for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since twitter updated it's logo it makes sense to update it in the theme.