Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the top margin a bit #619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

melroy89
Copy link
Contributor

@melroy89 melroy89 commented Feb 4, 2023

Decrease the top margin of the side panel on large displays from mt6 to mt3.

Especially having table of contents enabled (toc: true) the content of the side panel is not easily identified as such. Actually the TOC is almost off the screen.. :\

So less ideal. In my case people should detect the table of contents easier.

For reference, I'm using a 1920x1080 panel.

Decrease the top margin of the side panel on large displays to mt3.
@netlify
Copy link

netlify bot commented Feb 4, 2023

Deploy Preview for gohugo-ananke-theme-demo canceled.

Name Link
🔨 Latest commit afde5e0
🔍 Latest deploy log https://app.netlify.com/sites/gohugo-ananke-theme-demo/deploys/63dda87a283b720008645a27

@melroy89
Copy link
Contributor Author

melroy89 commented Feb 8, 2023

Or maybe even better, remove this mt6-l all together.

@regisphilibert
Copy link
Member

@budparr this is some design consideration.

@ramiro
Copy link
Contributor

ramiro commented Apr 30, 2024

Wouldn't it be better to make the whole aside right side lateral block conditional on the toc front matter option actually being enabled?

If, in the demo site, you compare a blog post (e.g. Chapter VI: Esmeralda) with the About page on a medium sized computer display (no need for it to be any of the very high DPI panels available now) you can see the former's body is placed too to the left with too much white space on the right and in comparison the latter looks more pleasantly centered on the screen.

@melroy89
Copy link
Contributor Author

Wouldn't it be better to make the whole aside right side lateral block conditional on the toc front matter option actually being enabled?

If, in the demo site, you compare a blog post (e.g. Chapter VI: Esmeralda) with the About page on a medium sized computer display (no need for it to be any of the very high DPI panels available now) you can see the former's body is placed too to the left with too much white space on the right and in comparison the latter looks more pleasantly centered on the screen.

Both yes. this PR is mainly about the top, but sure also the centering is an issue, when you don't enabled the toc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants