*: Promql changes to add support to extended functions throught Thanos #7338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-stanaka
force-pushed
the
fix/extended-functions-support
branch
from
6744a2e
to
8ce9d68
Compare
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Extending test to check behavior More missing imports Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
pedro-stanaka
force-pushed
the
fix/extended-functions-support
branch
from
8ce9d68
to
422f8f4
Compare
GiedriusS
previously approved these changes
May 6, 2024
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
pedro-stanaka
force-pushed
the
fix/extended-functions-support
branch
from
514f6ad
to
8fd13b6
Compare
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
pedro-stanaka
force-pushed
the
fix/extended-functions-support
branch
from
8fd13b6
to
b2da243
Compare
GiedriusS
approved these changes
May 7, 2024
Nashluffy
pushed a commit
to Nashluffy/thanos
that referenced
this pull request
May 14, 2024
thanos-io#7338) * fixing extended functions support in more places Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Adding new failint for the Parse() method Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Adding new method for ParseMetricSelector Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Fixing missing imports Extending test to check behavior More missing imports Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Fixing method name Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Solving references to forbidden functions Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Treating promql validation from ParseExpr Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * fixing funcs Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> --------- Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> Signed-off-by: mluffman <nashluffman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #7331.
Changes
In this PR I am introducing a new faillint rule to avoid using prometheus parser directly, but rather use our internal parser
package that has support for extended functions (xrate, xincrease, etc.).