[WIP] Index cache clients : Dedup Index Cache requests #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
|
@yeya24 @GiedriusS @MichaHoffmann can you PTAL , am i heading towards correct approach? |
GiedriusS
reviewed
May 9, 2024
| @@ -456,6 +462,43 @@ func (c *memcachedClient) GetMulti(ctx context.Context, keys []string) map[strin | |||
| return hits | |||
| } | |||
|
|
|||
| func (c *memcachedClient) GrabKeys(ctx context.Context, keys []string) map[string][]byte { | |||
| var group singleflight.Group | |||
There was a problem hiding this comment.
You need to create this group only once, inside the memcachedClient.
| // RemoteCacheClient is a high level client to interact with remote cache. | ||
| type RemoteCacheClient interface { | ||
| // ReadThroughRemoteCache is a high level client to interact with remote cache. | ||
| type ReadThroughRemoteCache interface { |
There was a problem hiding this comment.
Read-through means that we should start our work from refactoring the internal interfaces so that the order of operations wouldn't be (this is the state right now):
- Get from cache
- If not in cache, fetch the actual data
- Put it back in cache
It must be:
- GetSomeData() would be called consistently inside Thanos and it would do the following only once:
- Get from cache
- If not in cache, fetch the actual data
- Put it back in cache
So, instead of each action being separate, you would do all of this only once. Does it make sense? :) I would suggest starting from one data type only e.g. postings and then work from there.
Vanshikav123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#7169
This change makes sure that if several requests ask for the same information at almost the same time, the system handles them together instead of repeating the same task multiple times unnecessarily.