fetcher: sanity check metas for common corruptions #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
reviewed
Apr 16, 2024
fpetkovski
reviewed
Apr 16, 2024
fpetkovski
reviewed
Apr 16, 2024
MichaHoffmann
force-pushed
the
mhoffm/sanity-check-metas-in-fetcher
branch
from
d87db53
to
59e33b9
Compare
MichaHoffmann
force-pushed
the
mhoffm/sanity-check-metas-in-fetcher
branch
2 times, most recently
from
ed43466
to
a7b5d56
Compare
MichaHoffmann
changed the title
MichaHoffmann
force-pushed
the
mhoffm/sanity-check-metas-in-fetcher
branch
from
a7b5d56
to
e730d58
Compare
Santiy check metas that are returned from fetcher for common issues. We currently return metas that will lead to crashes in compactor and store, this PR marks them as corrupted so that they will get cleaned up and are visible in metrics. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm/sanity-check-metas-in-fetcher
branch
from
e730d58
to
84ab6a0
Compare
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm/sanity-check-metas-in-fetcher
branch
from
c4f8a52
to
cba520b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Mark metas with incomplete files as corrupted. Once shipper uploads the meta, the block is considered complete. This should make it possible to use the "Files" field in meta for a cheap check if the block is valid if its already in object storage. Neither storage-gw nor compactor can handle incomplete blocks, so this should fix a couple runtime issues; produce metrics and automatically clean up this issue.
Added a flag to disable cleanup of partially uploaded blocks that defaults to true.
Verification
Added unittests
Should solve #6328