add context error check on merge of labels and label names #7277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlan-z
force-pushed
the
context-cancellation-checks-for-get-label-merge
branch
2 times, most recently
from
7e2933e
to
cf606be
Compare
| } | ||
|
|
||
| func mergeTwoStringSlices(a, b []string) []string { | ||
| func mergeTwoStringSlices(ctx context.Context, a, b []string) ([]string, error) { |
There was a problem hiding this comment.
I kinda dont understand why this function needs to check for context errors here. Its just processing two string slices.
There was a problem hiding this comment.
When slices are big enough, this merge was taking a lot of time and in cortex we saw it was processing even though request has timed out already, wasting the resources. I think this case is valid for Thanos as well.
yeya24
previously approved these changes
Apr 19, 2024
erlan-z
force-pushed
the
context-cancellation-checks-for-get-label-merge
branch
from
cf606be
to
9b78e27
Compare
Signed-off-by: Erlan Zholdubai uulu <erlanz@amazon.com>
erlan-z
force-pushed
the
context-cancellation-checks-for-get-label-merge
branch
from
9b78e27
to
ac4b0c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add context cancellation check on MergeSlices function in merge.go which is used on labels and label values merging.
Verification
Added unit test. However didn't add test case for context cancellation check because that would require wait time on tests which is not prefered.