Fixed windows compatibility issue, when storage gateway syncs index f… #7148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #7147 |
henrikschristensen
force-pushed
the
main
branch
3 times, most recently
from
70da760
to
7223ac2
Compare
| @@ -154,6 +155,8 @@ func WriteBinary(ctx context.Context, bkt objstore.BucketReader, id ulid.ULID, f | |||
| } | |||
|
|
|||
| if tmpFilename != "" { | |||
| // On windows renaming an open file will result in access denied error | |||
| bw.writer.Close() | |||
There was a problem hiding this comment.
I wonder if this will cause issues with the deferred close above
There was a problem hiding this comment.
I dont see a way to check if a filedescriptor has already been closed. Maybe the Close function could set the file descriptor to nil after a succesful close. The Close function should then start by checking for nil and exit if true.
henrikschristensen
force-pushed
the
main
branch
from
7223ac2
to
b3487cf
Compare
henrikschristensen
force-pushed
the
main
branch
3 times, most recently
from
3ef90ec
to
78086ee
Compare
henrikschristensen
force-pushed
the
main
branch
3 times, most recently
from
3718883
to
3fac2a7
Compare
…iles to local disk. Signed-off-by: henrikschristensen <51989221+henrikschristensen@users.noreply.github.com>
henrikschristensen
force-pushed
the
main
branch
from
3fac2a7
to
889b3f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iles to local disk.