Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule: fix empty $externalLabels when templating labels in rule. #5394

Merged
merged 1 commit into from May 30, 2022
Merged

rule: fix empty $externalLabels when templating labels in rule. #5394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/rules/manager.go
View file
Open in desktop
Expand Up @@ -382,7 +382,7 @@ func (m *Manager) Update(evalInterval time.Duration, files []string) error {
continue
}
// We add external labels in `pkg/alert.Queue`.
if err := mgr.Update(evalInterval, fs, nil, m.externalURL); err != nil {
if err := mgr.Update(evalInterval, fs, m.extLset, m.externalURL); err != nil {
// TODO(bwplotka): Prometheus logs all error details. Fix it upstream to have consistent error handling.
errs.Add(errors.Wrapf(err, "strategy %s, update rules", s))
continue
Expand Down