Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groupcache: fix handling of slashes #5357

Merged
merged 1 commit into from May 11, 2022

Commits on May 11, 2022

  1. groupcache: fix handling of slashes

    Use https://github.com/julienschmidt/httprouter#catch-all-parameters for
    the groupcache route otherwise slashes in the cache's key gets
    interpreted by the router and thus groupcache's function never gets
    invoked, and all clients get 404.
    
    Remove test regarding cache hit because now Thanos Store during test
    constantly generates cache hits due to 1s delay between block
    information refreshes.
    
    Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
    GiedriusS committed May 11, 2022
    Copy the full SHA
    4ae37f7 View commit details
    Browse the repository at this point in the history