Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidecar/compact/store/receiver - Add the prefix option to buckets #5337

Merged
merged 36 commits into from Jun 9, 2022
Merged

sidecar/compact/store/receiver - Add the prefix option to buckets #5337

merged 36 commits into from Jun 9, 2022

Commits on Jun 9, 2022

  1. Create prefixed bucket 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    de8dd26 View commit details
    Browse the repository at this point in the history

  2. started PrefixedBucket tests 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    64642db View commit details
    Browse the repository at this point in the history

  3. finish objstore tests 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    8e3e102 View commit details
    Browse the repository at this point in the history

  4. Simplify string removal logic 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    124bc43 View commit details
    Browse the repository at this point in the history

  5. Test more prefix cases on PrefixedBucket 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    0e55117 View commit details
    Browse the repository at this point in the history

  6. Only use a prefixedbucket if we have a valid prefix 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    fffb2ef View commit details
    Browse the repository at this point in the history

  7. Add single unit test for prefixedBucket prefix 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    eec2750 View commit details
    Browse the repository at this point in the history

  8. test other prefixes on UsesPrefixTest 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    d4a209f View commit details
    Browse the repository at this point in the history

  9. add remaining methods to UsesPrefixTest 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    d494c9e View commit details
    Browse the repository at this point in the history

  10. add prefix to docs examples 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    4161825 View commit details
    Browse the repository at this point in the history

  11. Simplify Iter method 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    e6a9fb5 View commit details
    Browse the repository at this point in the history

  12. add prefix explanation to S3 docs 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    e7ae910 View commit details
    Browse the repository at this point in the history

  13. Conclusion of prefix sentence on docs 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    6645a12 View commit details
    Browse the repository at this point in the history

  14. Use DirDelim instead of magic string 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    cba5d77 View commit details
    Browse the repository at this point in the history

  15. Add log when using prefixed bucket 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    ba98b22 View commit details
    Browse the repository at this point in the history

  16. Remove "@" from test string to make them simpler 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    d4acbb7 View commit details
    Browse the repository at this point in the history

  17. fix BucketConfig Config type - back to interface 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    5177900 View commit details
    Browse the repository at this point in the history

  18. add changelog 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    14db917 View commit details
    Browse the repository at this point in the history

  19. add missing checks in UsesPrefixTest 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    c30eb10 View commit details
    Browse the repository at this point in the history

  20. fix linter and test errors 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    776c17e View commit details
    Browse the repository at this point in the history

  21. Add license to new files 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    4ec141e View commit details
    Browse the repository at this point in the history

  22. Remove autogenerated docs 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    6ee2638 View commit details
    Browse the repository at this point in the history

  23. Remove duplicated transformation of string->[]byte 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    661b755 View commit details
    Browse the repository at this point in the history

  24. Add prefixed bucket on all e2e tests for S3 

    The idea is that if it works, we can add for all other providers.
Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    bd05bd9 View commit details
    Browse the repository at this point in the history

  25. Add e2e tests using prefixed bucket to all providers 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    5c8baee View commit details
    Browse the repository at this point in the history

  26. refactor: move validPrefix to prefixed_bucket logic 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    2c4fbc4 View commit details
    Browse the repository at this point in the history

  27. Enhance the documentation about prefix. 

    Signed-off-by: jademcosta <jademcosta@gmail.com>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    5173567 View commit details
    Browse the repository at this point in the history

  28. Fix format 

    Signed-off-by: jademcosta <jademcosta@gmail.com>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    435c130 View commit details
    Browse the repository at this point in the history

  29. Add prefix entry on bucket config example 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    5c0c3cc View commit details
    Browse the repository at this point in the history

  30. Removing redundancies on prefix checks and tests 

    We already check if the prefix if not empty when creating the bucket.

Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    e611858 View commit details
    Browse the repository at this point in the history

  31. Remove redundant YAML unmarshal 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    8926d2a View commit details
    Browse the repository at this point in the history

  32. Remove unused parameter 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    39c8dbf View commit details
    Browse the repository at this point in the history

  33. Remove docs that should be auto-geneated 

    Signed-off-by: jademcosta <jade.costa@nubank.com.br>
    @jademcosta @dudaduarte
    jademcosta authored and dudaduarte committed Jun 9, 2022
    Copy the full SHA
    3e04c41 View commit details
    Browse the repository at this point in the history

  34. refactor: move prefix to config root level 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    e4a03da View commit details
    Browse the repository at this point in the history

  35. add auto generated docs 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    a7a9229 View commit details
    Browse the repository at this point in the history

  36. fix changelog 

    Signed-off-by: Maria Eduarda Duarte <dudammduarte@yahoo.com.br>
    @dudaduarte
    dudaduarte committed Jun 9, 2022
    Copy the full SHA
    d72d645 View commit details
    Browse the repository at this point in the history