Skip to content

Commit

Permalink
Fix empty $externalLabels when templating labels in rule.
Browse files Browse the repository at this point in the history
Signed-off-by: Rostislav Benes <r.dee.b.b@gmail.com>
  • Loading branch information
roastiek committed May 29, 2022
1 parent 6a312a7 commit cb3e4a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/rules/manager.go
Expand Up @@ -382,7 +382,7 @@ func (m *Manager) Update(evalInterval time.Duration, files []string) error {
continue
}
// We add external labels in `pkg/alert.Queue`.
if err := mgr.Update(evalInterval, fs, nil, m.externalURL); err != nil {
if err := mgr.Update(evalInterval, fs, m.extLset, m.externalURL); err != nil {
// TODO(bwplotka): Prometheus logs all error details. Fix it upstream to have consistent error handling.
errs.Add(errors.Wrapf(err, "strategy %s, update rules", s))
continue
Expand Down

0 comments on commit cb3e4a2

Please sign in to comment.