Skip to content

Commit

Permalink
Ruler: Change default evaluation interval to 1m (#5417)
Browse files Browse the repository at this point in the history
* Change default eval interval to 1m

Signed-off-by: Matej Gera <matejgera@gmail.com>

* Update CHANGELOG

Signed-off-by: Matej Gera <matejgera@gmail.com>
  • Loading branch information
matej-g committed Jun 13, 2022
1 parent 5da60e0 commit 03775c2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -23,6 +23,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
### Changed

- [#5410](https://github.com/thanos-io/thanos/pull/5410) Query: Close() after using query. This should reduce bumps in memory allocations.
- [#5417](https://github.com/thanos-io/thanos/pull/5417) Ruler: Change default evaluation interval to 1 minute.

### Removed

Expand Down
2 changes: 1 addition & 1 deletion cmd/thanos/rule.go
Expand Up @@ -125,7 +125,7 @@ func registerRule(app *extkingpin.App) {
cmd.Flag("resend-delay", "Minimum amount of time to wait before resending an alert to Alertmanager.").
Default("1m").DurationVar(&conf.resendDelay)
cmd.Flag("eval-interval", "The default evaluation interval to use.").
Default("30s").DurationVar(&conf.evalInterval)
Default("1m").DurationVar(&conf.evalInterval)

conf.rwConfig = extflag.RegisterPathOrContent(cmd, "remote-write.config", "YAML config for the remote-write configurations, that specify servers where samples should be sent to (see https://prometheus.io/docs/prometheus/latest/configuration/configuration/#remote_write). This automatically enables stateless mode for ruler and no series will be stored in the ruler's TSDB. If an empty config (or file) is provided, the flag is ignored and ruler is run with its own TSDB.", extflag.WithEnvSubstitution())

Expand Down
2 changes: 1 addition & 1 deletion docs/components/rule.md
Expand Up @@ -310,7 +310,7 @@ Flags:
record's value. The URL path is used as a
prefix for the regular Alertmanager API path.
--data-dir="data/" data directory
--eval-interval=30s The default evaluation interval to use.
--eval-interval=1m The default evaluation interval to use.
--grpc-address="0.0.0.0:10901"
Listen ip:port address for gRPC endpoints
(StoreAPI). Make sure this address is routable
Expand Down

0 comments on commit 03775c2

Please sign in to comment.