Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bench-fast #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bench-fast #327

wants to merge 1 commit into from

Conversation

bazooka3000
Copy link

Modified the code to build smaller dataset for "make bench-fast" target.

@MichaHoffmann
Copy link
Contributor

This looks pretty good to me!

@bazooka3000
added bench-fast target in makefile
5c3da89 
Signed-off-by: bazooka3000 <dattatreya.git@gmail.com>
@bazooka3000 bazooka3000 reopened this Nov 23, 2023
@bazooka3000 bazooka3000 marked this pull request as ready for review November 23, 2023 10:17
GiedriusS
GiedriusS reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this complexity is needed - why not just skip over the long running benchmarks if https://pkg.go.dev/testing#Short is set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bazooka3000 @MichaHoffmann @GiedriusS