execution,engine: respect configured max samples #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-add-sample-limits
branch
2 times, most recently
from
21c457f
to
2c86320
Compare
MichaHoffmann
force-pushed
the
mhoffm-add-sample-limits
branch
4 times, most recently
from
dd79a7a
to
9bb2f53
Compare
GiedriusS
reviewed
Aug 17, 2023
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-add-sample-limits
branch
5 times, most recently
from
836a40a
to
d9fc3c2
Compare
fpetkovski
reviewed
Aug 17, 2023
execution/limits/limits.go
Outdated
| "github.com/thanos-io/promql-engine/query" | ||
| ) | ||
|
|
||
| type Limits struct { |
There was a problem hiding this comment.
I think this should be an interface and we should have a nop implementation to avoid going through locks when limits are not configured.
There was a problem hiding this comment.
Removed the locks but there is a short circuit if we have no limit at the start anyhow!
MichaHoffmann
force-pushed
the
mhoffm-add-sample-limits
branch
8 times, most recently
from
3d650aa
to
bfeae3a
Compare
MichaHoffmann
force-pushed
the
mhoffm-add-sample-limits
branch
2 times, most recently
from
64226bb
to
63f370e
Compare
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-add-sample-limits
branch
from
63f370e
to
cf9d7f9
Compare
MichaHoffmann
force-pushed
the
mhoffm-add-sample-limits
branch
2 times, most recently
from
0aeafa9
to
318b752
Compare
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-add-sample-limits
branch
from
4c647ab
to
8c465ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to start to respect the provided max sample limit from the promql options. It only pipes the sample limits through to matrix and vector selectors.