fmt: format load strings in tests #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-autoformat-load-directives
branch
6 times, most recently
from
c1f52bb
to
ba092b5
Compare
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-autoformat-load-directives
branch
from
ba092b5
to
daeac04
Compare
saswatamcode
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Maybe we can just put this in scripts dir?
There was a problem hiding this comment.
Maybe making this into its own module, so that it is separately installable might be better, in case we want to upstream it for use in prometheus/prometheus at some point? 🙂
| return true | ||
| } | ||
| cont := s.Value[1 : len(s.Value)-1] | ||
| if !strings.HasPrefix(cont, "load") { |
There was a problem hiding this comment.
I think there are other directives as well like clear and eval: https://github.com/prometheus/prometheus/blob/main/promql/test.go#L252
There was a problem hiding this comment.
i was intending it only to format our tests for now; to do it properly we would need to be able to parse those load directives.
GiedriusS
reviewed
Jun 14, 2023
|
Running it in the CI seems like a good idea 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a small tool so we can auto-format indentation for load statements.