#138 : Added absent_over_time support function #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,13 @@ var Funcs = map[string]FunctionCall{ | |||
| "deg": simpleFunc(func(v float64) float64 { | |||
| return v * 180 / math.Pi | |||
| }), | |||
| "absent_over_time": simpleFunc(func(v float64) float64 { | |||
There was a problem hiding this comment.
i dont think the implementation works; this operator actually needs to be a source of new samples ( if there are no samples in the window ). only implemented as simpleFunc it can only transform preexisting samples. Can you take a look at my previous PR for the absent function? I had to introduce a new operator that actually produces new samples in that case. It might be possible to adapt this for the "_over_time" variant too, but it might be a bit harder because functions are pushed down into the matrix selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.