Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: fix when endpoint is empty #95

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

azure: fix when endpoint is empty #95

wants to merge 2 commits into from

Conversation

kartikaysaxena
Copy link

@kartikaysaxena kartikaysaxena commented Jan 5, 2024 •
edited

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Should fix thanos-io/thanos#6175

Changes

Check if endpoint provided is empty in while validating the configuration

@kartikaysaxena
fix when endpoint is empty
5f6baef 
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
@kartikaysaxena
Copy link
Author

PTAL @yeya24 @bwplotka

squat
squat approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GiedriusS
GiedriusS reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is correct? Shouldn't endpoint be set to the default value if it is ""?

@kartikaysaxena
use default endpoint
5321105 
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
@kartikaysaxena
Copy link
Author

I'm not sure if this is correct? Shouldn't endpoint be set to the default value if it is ""?

Thanks for the suggestion! Taken into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@GiedriusS GiedriusS Awaiting requested review from GiedriusS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Object Storage endpoint default behaviour has a breaking change in 0.31.0
3 participants
@kartikaysaxena @GiedriusS @squat