Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Object Storage endpoint default behaviour has a breaking change in 0.31.0 #6175

Open
verejoel opened this issue Mar 1, 2023 · 1 comment · May be fixed by thanos-io/objstore#95
Open

Azure Object Storage endpoint default behaviour has a breaking change in 0.31.0 #6175

verejoel opened this issue Mar 1, 2023 · 1 comment · May be fixed by thanos-io/objstore#95

Comments

@verejoel
Copy link
Contributor

verejoel commented Mar 1, 2023

thanos-io/objstore#35 introduced a change to the way Azure endpoint default value is calculated. Previously, setting endpoint: "" in the object storage config would mean the default endpoint would be used. In v0.31.0, setting endpoint: "" overrides the default, leading to errors when attempting to create a bucket client.

The issue was introduced by f9d07a3 which in-turn brought in the changes from thanos-io/objstore#35.

This issue was first discussed in a slack thread.
@matej-g
Copy link
Collaborator

matej-g commented Mar 2, 2023

Thanks for reporting this! I wonder if this is a common occurrence (users configuring endpoint: "") and should be fixed or whether it suffices to document this 🤔. IMHO first solution would be more proper.

@alanprot alanprot mentioned this issue Jul 10, 2023
Open
@kartikaysaxena kartikaysaxena linked a pull request Jan 5, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

azure: fix when endpoint is empty kartikaysaxena/objstore
2 participants
@matej-g @verejoel