Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive: Removing version from label selector so that version updates are working #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjastrzabek-roche
Copy link

Removing version from label selector so that version updates are working.

Currently it would throw an error like:

Deployment/thanos/thanos-receive-router dry-run failed, reason: Invalid, error: Deployment.apps "thanos-receive-router" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"thanos-receive-router", "app.kubernetes.io/instance":"thanos-receive", "app.kubernetes.io/name":"thanos-receive", "app.kubernetes.io/version":"v0.29.0"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

Signed-off-by: pjastrzabek-roche 105636104+pjastrzabek-roche@users.noreply.github.com

Removing version from label selector so that updates of that components are working.

Signed-off-by: pjastrzabek-roche <105636104+pjastrzabek-roche@users.noreply.github.com>
@pjastrzabek-roche
Copy link
Author

what exactly is wrong with that build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant