Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[notifications] fix SnoreToast implementation #941

Merged
merged 2 commits into from
Jan 14, 2023
Merged

[notifications] fix SnoreToast implementation #941

merged 2 commits into from
Jan 14, 2023

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Jan 7, 2023 •
edited

see mikaelbr/node-notifier#424

use SnoreToast CLSID https://github.com/KDE/snoretoast/blob/master/CMakeLists.txt#L5

thus custom compilation of SnoreToast can be deleted, aka revert #600

Important notes:

  • The CLSID will need to be updated if node-notifier updates their SnoreToast version
  • Need to build & install & run once before this can be tested in dev mode

will fix #848, fix #939

@th-ch th-ch merged commit 6edc94a into th-ch:master Jan 14, 2023
@Araxeus Araxeus changed the title fix SnoreToast implementation [notifications] fix SnoreToast implementation Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Araxeus @th-ch