Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notification showing appID instead of app name on windows #270

Merged
merged 7 commits into from
May 16, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented May 10, 2021

Before:

appID Unset

After:

appID Fixed

This sets the appID +
if not in dev mode OR running from portable app -> check the windows startMenu shortcut and fix it if necessary,
(Since this fix works only if shortcut is correctly registered in startMenu)

This only fix normal notifications. fix for interactive notifications is coming soon

Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks ok, thanks for the improvement! Merging ✅

@th-ch th-ch merged commit 5bc8e86 into th-ch:master May 16, 2021
@Araxeus Araxeus deleted the fix-normal-notification-showing-appID branch May 18, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants