-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore codeowners that got previously removed from review #72007
Conversation
Why is this an opt in configuration? I can't imagine anyone ever wanting this off |
Because if I made it a default I would have needed to increase the version number to 2 because it would be a breaking change, which would have also meant needing to make a V2 branch, because of how Github actions works |
I think it's a bug fix more than a breaking change tbh I don't think it's preferred I think I'm just the first person to remove themselves from reviews |
Neat. I didn't know you could do that with branches. I have always gone the tag/release route or to be extra safe used the exact commit hash. |
Yeah I got the idea from actions/toolkit#214 |
I'm gonna close this since we agreed (I think) on coderbus that this should be considered a bug fix and require no config changes |
@@ -27,3 +27,4 @@ jobs: | |||
with: | |||
separator: ' ' | |||
users: ${{ steps.CodeOwnersParser.outputs.owners }} | |||
ignoreRemovedUsers: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gamer025 wants me to test something
About The Pull Request
Only merge this after the following 2 PRs got merged!
tgstation/RequestReviewFromUser#5
tgstation/RequestReviewFromUser#6
Makes it so that codeowners no longer get notified if they got removed from review previously in the PRs lifetime
Requested by @Mothblocks
Why It's Good For The Game
Apparently no means no and the action constantly re-adding you as owner after you remove yourself is annoying
Changelog