Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update to slurm_singularity's auto gpu detection and configuring setup.py to use networkx>=2.6,<3 #167

Merged
merged 2 commits into from Nov 17, 2023

Conversation

bryce-turner
Copy link
Member

Small update to slurm_singularity's auto gpu detection and configuring setup.py to use networkx>=2.6,<3.

The gpu detection is a nice to have, but not required since the pipeline designer can and should --nv as part of the runner_args.

Networkx typically supports 3-4 major python releases, networkx 3.0 supports 3.8, 3.9, 3.10, and 3.11, which overlaps our supported python versions, but it adds the following change that impacts our usage:

If you use the presence of the attribute _adj as a criteria for the object being a Graph instance, that code may need updating. The graph classes themselves now have an attribute _adj. So, it is possible that whatever you are checking might be a class rather than an instance.

We will plan to migrate networkx 3.x in a future jetstream release - particularly as certain python versions approach EOL.

@bryce-turner bryce-turner merged commit ecd8dfd into develop Nov 17, 2023
5 checks passed
@bryce-turner bryce-turner deleted the improve_gpu_detection_and_update_setup_py branch November 17, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant