Updates to follow pep 440 versioning for pipelines #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imilar labels as an alias to grabbing the most recent pipeline version This allows us to be able to request "pipeline@1.0.0.dev1" via "pipeline@development". Additionally if "pipeline@development" does exist in the search path, it is considered as the most recent version.
…on the os.dir find order)
… and we can say that v1.0.0 is logically equivalent to 1.0.0 when a user requests pipeline@1.0.0
…re SIGPIPE friendly. These changes allow for a cleaner output from `jetstream pipelines -v pipeline@v1.0.0 | head`.
…ld be more SIGPIPE friendly. These changes allow for a cleaner output from `jetstream pipelines -v pipeline@v1.0.0 | head`." This reverts commit af24a18. Previous commit failed pytest and this isn't in the scope of the features for this branch.
ChristopheLegendre
approved these changes
Nov 2, 2023
PedalheadPHX
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to follow pep 440 versioning for pipelines, this is close to how we have been versioning the pipelines already, but now we will better support the usage of the dev, alpha, beta, and rc identifiers; additionally, versions with and without
v. Along with this, we now can usedevelopmentas an alias to grabbing the most recent dev version of a pipeline. Legacy pipelines that are usingdevelopmentas their version will still be considered as the most recent dev version, otherwise the sort order is largely the same a before.This also fixes a bug that pops up with using packaging >= 22.0, as in this version range
developmentis not a valid version. We override this behavior and say thatdevelopmentis the highest version possible and is still considered as a dev version.For example if given the following versions:
We should now expect the following behavior:
If we still have legacy versions, e.g.:
we expect the following behavior:
Finally,
jetstream pipelineswill now return a sorted list, previously this was somewhat random as there was not a function for identifying if one version was greater than the other in terms of sort order. This is fixed by adding__eq__and__lt__.