Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using restframework-gis OpenAPI schema creation #532

Closed
wants to merge 4 commits into from

Conversation

Christiaanvv
Copy link

Included the new restframework-gis OpenAPI schema support, see openwisp/django-rest-framework-gis#223

@Christiaanvv
Copy link
Author

Christiaanvv commented Sep 22, 2021

@tfranzel I tried to include openwisp/django-rest-framework-gis#223 into this project. It is a very simple solution but there are a few problems with the current approach where I need your help with:

  • Only include restframework-gis when a GeometryField or GeoFeatureModelListSerializer is encountered
  • Only include restframework-gis if it is installed.
  • Include it in other files than openapi.py
  • Write tests for this approach.

Since I am fairly new to contributing to a project, I need some guidance. Can you help me?

@Christiaanvv Christiaanvv changed the title Tried to add GeometryField and GeoFeatureModelListSerializer support Using restframework-gis OpenAPI schema creation Sep 22, 2021
@tfranzel
Copy link
Owner

hi @Christiaanvv, there are a bunch of things you need to know before attempting to do this. you need to read up these things:

#67 basically contains all the mechanics necessary, but with a gis implementation independent of openwisp/django-rest-framework-gis#223. easiest way is to switch out the gis part in #67.

it is still an open question which approach is the better one.

@tfranzel
Copy link
Owner

this PR got superseded by #746. discussion&feedback continues there.

@tfranzel tfranzel closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants