Vue 2.7 refresh #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, so neflify checks failed as @vue/cli-service@5.0.8 requires node >= 12, and those checks are running on node 10. Oops. |
|
Thanks for the PR! I added a |
tfeldmann
added a commit
that referenced
this pull request
Feb 27, 2023
This reverts commit 6069136.
|
Oops, I was a bit fast with this one. The icons are much too big now. Care to investigate? |
tfeldmann
added a commit
that referenced
this pull request
Feb 27, 2023
I filed an updated PR, which corrects the icon size problem (pending a real fix in fa). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First, thanks for writing this app. It's pretty nice!
Anyways, I tried building this with node18, and it fails to compile. After dropping back to node14, it would compile, but only if I didn't change package-lock.json. So, I eventually did a refresh, fixed some eslint bugs, and everything is update, using vue 2.7.14 and @fortawesome/vue-fontawesome@2.
The icons are a little larger with this version though. I'm not so familiar with FA, but maybe I'll look more at this change.
You also might not want the automatic lint changes. I so, I can drop that last commit from this PR.
Cheers,
John