Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize monitoring RPCs #793

Merged
merged 11 commits into from Sep 29, 2021
Merged

Optimize monitoring RPCs #793

merged 11 commits into from Sep 29, 2021

Conversation

adonagy
Copy link
Contributor

@adonagy adonagy commented Sep 29, 2021 •
edited

Includes optimization for the monitoring RPCs.

Still some stuff left to do:

  • Fix leftover TODOs
  • cleanup code

bkontur
bkontur reviewed Sep 29, 2021
View reviewed changes
rpc/src/server/mod.rs Outdated Show resolved Hide resolved
bkontur
bkontur approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adonagy
please, check that last one :D

@adonagy adonagy marked this pull request as ready for review September 29, 2021 15:09
@adonagy
Copy link
Contributor Author

adonagy commented Sep 29, 2021

@bkontur Thank you for the review! Will squash and merge after CI passes

@adonagy adonagy merged commit d330f0f into develop Sep 29, 2021
@adonagy adonagy deleted the fix/rpc-timeouts branch September 29, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkontur bkontur bkontur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adonagy @bkontur