compiler: zero-initializes moduleInstanceAddress of call engine #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetake
force-pushed
the
testfixreset
branch
from
f8e55b1
to
98703be
Compare
mathetake
commented
Aug 31, 2022
|
will backfill more tests, but this should fix inkeliz/karmem#85 and aquasecurity/trivy#2791 @codefromthecrypt @inkeliz @knqyf263 |
mathetake
changed the title
mathetake
changed the title
|
ok verified that at least on my local machine, the PRs ^^ pass all tests. will do the backfilling |
codefromthecrypt
approved these changes
Aug 31, 2022
mathetake
commented
Aug 31, 2022
| @@ -558,50 +558,53 @@ func testCloseInFlight(t *testing.T, r wazero.Runtime) { | |||
|
|
|||
| func testMemOps(t *testing.T, r wazero.Runtime) { | |||
There was a problem hiding this comment.
so this was exactly the same pattern in trivy and karmen - calling exported functions which might grow memory. But in order to catch this bug, I had to reuse the same api.Function, so I fixed it in that way.
There was a problem hiding this comment.
and verified that without the patch, this test fails!
codefromthecrypt
added a commit
to tetratelabs/proxy-wasm-go-sdk
that referenced
this pull request
Aug 31, 2022
A bug in beta1 is fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to tetratelabs/wazero-fuzz
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/javy-wazero
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/wazero-demo
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/wazero-demo
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/goissues
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
F21
pushed a commit
to F21/javy-wazero
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/sdfx-isosurface
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/wapc-guest-tinygo
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/mjml-go
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
F21
pushed a commit
to Boostport/mjml-go
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/RethinkRAW
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/go-zbar-wasm
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
Yeicor
pushed a commit
to Yeicor/sdfx-isosurface
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to codefromthecrypt/capsule
that referenced
this pull request
Aug 31, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
pkedy
pushed a commit
to wapc/wapc-guest-tinygo
that referenced
this pull request
Sep 1, 2022
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io> Signed-off-by: Adrian Cole <adrian@tetrate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #761 where the reuse of the api.Function
causes some trouble around module context initialization.
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io