Externalize compilation cache by compilers #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetake
commented
Aug 18, 2022
| @@ -50,11 +52,39 @@ func BenchmarkInitialization(b *testing.B) { | |||
| } | |||
| } | |||
|
|
|||
| func runInitializationBench(b *testing.B, r wazero.Runtime) { | |||
| func BenchmarkCompilation(b *testing.B) { | |||
There was a problem hiding this comment.
Result:
BenchmarkCompilation
BenchmarkCompilation/with_extern_cache
BenchmarkCompilation/with_extern_cache-10 2008 526860 ns/op
BenchmarkCompilation/without_extern_cache
BenchmarkCompilation/without_extern_cache-10 165 7080493 ns/op
mathetake
commented
Aug 18, 2022
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
codefromthecrypt
approved these changes
Aug 18, 2022
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the experimental support of the file system compilation cache.
Notably,
experimental.WithCompilationCacheDirNameallows users to configurewhere the compiler writes the cache into.
Versioning/validation of binary compatibility has been done via the release tag
(which will be created from the end of this month). More specifically, the cache
file starts with header with the hardcoded wazero version.
Note the cache implementation doesn't do any security mitigation like signing/verification,
and that would be a future TODO once we reach some stability.
The end-to-end test will be added in a subsequent PR.
Fixes #618