compiler: remove embedding of pointers of jump tables #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetake
changed the title
mathetake
commented
Jun 23, 2022
| @@ -8,69 +8,47 @@ import ( | |||
| "github.com/tetratelabs/wazero/internal/asm" | |||
| ) | |||
|
|
|||
| type constPool struct { | |||
There was a problem hiding this comment.
consolidated constPool impls into asm/assembler.go
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
codefromthecrypt
approved these changes
Jun 23, 2022
| @@ -53,11 +53,63 @@ type ConstantValue = int64 | |||
|
|
|||
| // StaticConst represents an arbitrary constant bytes which are pooled and emitted by assembler into the binary. | |||
| // These constants can be referenced by instructions. | |||
| type StaticConst = []byte | |||
| type StaticConst struct { | |||
| Raw []byte | |||
There was a problem hiding this comment.
Do I understand that raw means we don't know the encoding because it could be anything? ex string iee754 etc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the embedding of pointers of jump tables (uintptr of []byte)
used by BrTable operations. That is the last usage of unsafe.Pointer in
compiler implementations.
Alternatively, we treat jump tables as asm.StaticConst and emit them
into the constPool already implemented and used by various places.
Notably, now the native code compiled by compilers can be reusable
across multiple processes, meaning that they are independent of
any runtime pointers.
part of #618
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io