amd64: removes embeddings of pointers of bit masks for FP arithmetics #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
changed the title
mathetake
changed the title
mathetake
commented
Jun 22, 2022
| ) | ||
|
|
||
| func init() { | ||
| // TODO: what if these address exceed 32-bit address space? Even though AMD says 2GB memory space |
There was a problem hiding this comment.
This is the TODO this PR resolves
codefromthecrypt
approved these changes
Jun 22, 2022
| panic("CompileLoadStaticConstToRegister cannot be supported by golang-asm") | ||
| // CompileStaticConstToRegister implements Assembler.CompileStaticConstToRegister. | ||
| func (ta *testAssembler) CompileStaticConstToRegister(asm.Instruction, []byte, asm.Register) (err error) { | ||
| panic("CompileStaticConstToRegister cannot be supported by golang-asm") |
There was a problem hiding this comment.
I can see a near future where this module ends up not usable anymore ;)
There was a problem hiding this comment.
yeah for sure eventually removed :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes part of the embeddings of raw pointers (uintptr) into the
native code on amd64 backed. Specifically, this removes the embeddings
of bit mask constants used for FP arithmetic.
This is necessary to make compiled code reusable across multiple
processes.
part of #618