Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, notably Go 1.18 #17

Merged
merged 1 commit into from May 8, 2022
Merged

Update dependencies, notably Go 1.18 #17

merged 1 commit into from May 8, 2022

Conversation

codefromthecrypt
Copy link
Contributor

@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Mar 16, 2022

Note: the only glitch people may notice is when running make lint or similar, as not all linters updated. golint automatically disables those that don't update. See golangci/golangci-lint#2649

See https://go.dev/blog/go1.18

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Contributor Author

@mathetake PTAL, figured I'd update car and func-e to go 1.18, now that things work.

@@ -1,15 +1,15 @@
module github.com/tetratelabs/car

// This project uses go:embed, so requires minimally go 1.16
go 1.17
go 1.18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: this is read by golangci-lint to know whether or not to disable <1.18 linters

@codefromthecrypt codefromthecrypt merged commit b605755 into master May 8, 2022
@codefromthecrypt codefromthecrypt deleted the go-1.18 branch May 8, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants