Update select2entity.js #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi there. the ajax url seem to be unchangeable. Can you make it using de data-ajax--url one ?
|
Hello, can someone merge this PR ? |
|
I'll merge this. I'm taking a gamble because I'm not in a position to test but it seems harmless enough. I guess it fixes the bug related to this: select2/select2#5180 (comment) My main concern is that we don't break users on Select2 4.0.5 where the data attribute is working but according to this https://select2.org/configuration/data-attributes the data attributes override object settings so there's no problem for it to be set in both places. I'll wait a while before tagging a release in case there are any issues. Thanks for your patience. I know I've somewhat dropped the ball on this project in the last couple of years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. the ajax url seem to be unchangeable. Can you make it using de data-ajax--url one ?