This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
Added ExclusionStrategy to be used when serializing command reports. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exclusion strategy makes sure to skip serialization of any classes implementing the WebDriver interface. Since this object is redundant when reporting command parameters and doesn’t pass serialization - we exclude it. See google/gson#1540 for more details on the serialization problem. (edited) Signed-off-by: Gil Eliyahu <gil.eliyahu@testproject.io>
…xecution. Signed-off-by: Gil Eliyahu <gil.eliyahu@testproject.io>
|
Can't run CI on forked PRs for now, closing. |
mstrelex
pushed a commit
that referenced
this pull request
Aug 7, 2020
Added ExclusionStrategy to be used when serializing command reports. #22
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exclusion strategy makes sure to skip serialization of any classes implementing the WebDriver interface.
Since this object is redundant when reporting command parameters and doesn’t pass serialization - we exclude it.
See google/gson#1540 for more details on the serialization problem.
Fixes #21