Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeforeGroups should run before any matched test #2749

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

velma
Copy link
Contributor

@velma velma commented Apr 14, 2022

Closes #2359

Fixes #2359 .

There is possibility that BeforeGroups method will be run in parallel with test(s) that have this group assigned (see test case), this pull request fixed this situation

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

@krmahadevan
Copy link
Member

@velma - Please run ./gradlew autostyleApply to fix formatting violations and update this PR so that the tests can run.

@krmahadevan
Copy link
Member

@velma - thanks for taking the time to create a sample for the issue and also go the extra mile by helping out with a PR to fix the problem and also sharing the additional context around the review comments. Appreciate your time and effort.

Once @juherr takes a look at this PR and approves this PR, we can get this changeset merged into master.

We look forward to more such valuable contributions from you

@krmahadevan krmahadevan added this to the 7.6.0 milestone Apr 19, 2022
@krmahadevan krmahadevan removed this from the 7.6.0 milestone Apr 19, 2022
@krmahadevan krmahadevan merged commit 19010bd into testng-team:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testng @BeforeGroups is running in parallel with testcases in the group
3 participants