Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuiteRunner could not be initial by default Configuration #2744

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

bj-9527
Copy link
Contributor

@bj-9527 bj-9527 commented Mar 22, 2022

Fixes #2743.

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

public void testSuiteRunnerWithDefaultConfiguration() {
TestNG testNG = create(SuiteRunnerIssueTestSample.class);
testNG.run();
Assert.assertNotNull(SuiteRunnerIssueTestSample.suiteRunner);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bj-9527 - This assertion looks suspicious. Can we change this assertion such that it checks if the run() was successful by checking the exit code instead ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have change Assert to check status

@juherr juherr merged commit f4eaf4a into testng-team:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SuiteRunner could not be initial by default Configuration
3 participants