Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeConfiguration() listener method should be invoked for skipped configurations as well #2732

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

bj-9527
Copy link
Contributor

@bj-9527 bj-9527 commented Feb 18, 2022

beforeConfiguration() listener method should be invoked for skipped configurations as well

Fixes #2729

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

@krmahadevan
Copy link
Member

@bj-9527 - Thanks for submitting this PR. The changes look good to me. Once @juherr approves we can get this merged.

@juherr juherr merged commit 0438740 into testng-team:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beforeConfiguration() listener method should be invoked for skipped configurations as well
3 participants