Add XSD file for validation

[juherr]

• Add test case(s)
• Update CHANGES.txt

TODO:

• upgrade schema version and remove deprecated
• generate POJO from XSD.

[krmahadevan]

@juherr - If you find some time please help let me know your thoughts on the two questions i posted. Post which I think we can get this PR merged.

[juherr]

@krmahadevan sure. But I don't see them. Did you finish the review?

[krmahadevan]

@juherr - Am assuming that we built this xsd on an as-is basis from the DTD. Should we move the below tags out from the minOccurs because I am not sure if anyone would give a value like this :

	<listeners>
		<listener class-name="foo"/>
	</listeners>
	<listeners>
		<listener class-name="bar"/>
	</listeners>

• listeners
• packages
• method-selectors
• suite-files

ideally speaking these elements are supposed to be present only once per <suite> tag.

WDYT ?

[juherr]

Totally agree!

The dtd to xsd migration was not perfect and I missed things for sure

[krmahadevan]

Oh you migrated this by hand is it ? I also tried some tool but it showed a lot of errors when i attempted to open up the generated xsd in visual studio code.

Are you going to be fixing this or we circle back to this later and for now go ahead with having an XSD as a starting point ?

[juherr]

I used a tool for the generation but I had to fix it by hand.

I will adapt according to your remarks.

[juherr]

In fact, the default value for maxOccurs is already 1.

[krmahadevan]

@juherr - If we put all the <xsd:element> within <xsd:choice> which has a min and max set, doesnt it mean that these tags can be repeated multiple number of times ? I dont see the same thing done for <xsd:element ref="groups">

[juherr]

Good catch.
I think groups should be added to the choice too.
I will try different options.

[krmahadevan]

@krmahadevan sure. But I don't see them. Did you finish the review?

My bad. Forgot that. Now I finished it.

[juherr]

@krmahadevan Please check the description again before merging.
If you want to check XML samples, just add one suite file into the testng-core/src/test/resources/samples/xsd folder and my tests will check its validity.
If you think the XML is wrong and the test keep to be green, it will mean that the schema is not good enough =)

[juherr]

TODO: generate POJO from XSD.

[krmahadevan]

@juherr - Can you please fix the merge conflict ? We can merge this after that.

[krmahadevan]

ping @juherr

[juherr]

ping @juherr

I am doing my best to close it asap ;)