Comparing collection using equals method for assertEquals

CHANGES.txt

@@ -1,4 +1,5 @@
 Current
+Fixed: GITHUB-2296: assertEquals doesn't work for sets as order is not guaranteed. (Prashant Maroti)
 Fixed: GITHUB-1632: throwing SkipException sets iTestResult status to Failure instead of Skip (Julien Herr & Krishnan Mahadevan)
 New  : GITHUB-2456: Add onDataProviderFailure listener (Krishnan Mahadevan)
 Fixed: GITHUB-2445: NPE in FailedReporter.java With Tests Created in Factory (Arham Jain)

src/main/java/org/testng/Assert.java

@@ -12,6 +12,7 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 import org.testng.collections.Lists;
 
@@ -1074,7 +1075,7 @@ public static void assertEquals(Collection<?> actual, Collection<?> expected) {
    * @param message  the assertion error message
    */
   public static void assertEquals(Collection<?> actual, Collection<?> expected, String message) {
-    if (actual == expected) {
+    if (Objects.equals(actual, expected)) {
       return;
     }
 

src/test/java/org/testng/AssertTest.java

@@ -41,6 +41,13 @@ public void nullSetAssertEquals() {
     Assert.assertEquals(actual, expected);
   }
 
+  @Test
+  public void testSetAssertEquals() {
+    final Collection expected = Sets.newHashSet(new Asymmetric(10, 'a'), new Asymmetric(11, 'b'));
+    final Collection actual = Sets.newHashSet(new Asymmetric(11, 'b'), new Asymmetric(10, 'a'));
+    Assert.assertEquals(actual, expected);
+  }
+
   @Test
   public void nullMapAssertEquals() {
     Map expected = null;