Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test scenario for @BeforeGroups having a dependsOnGroups #2025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a test scenario for @BeforeGroups having a dependsOnGroups #2025

wants to merge 1 commit into from

Conversation

jobayle
Copy link

@jobayle jobayle commented Mar 5, 2019

TestNG ignores the dependsongroups parameter on @BeforeGroups annotations.

See: https://stackoverflow.com/questions/31929690/beforegroups-method-ignores-dependsongroups

TestNG ignores the dependsongroups parameter on @BeforeGroups
annotations.
@juherr
Copy link
Member

juherr commented Mar 7, 2019

Thanks for the test case but it doesn't follow the current convention.

BTW, I suppose it is a graph issue not covered by tests.

@krmahadevan Do you have time to check it?

@krmahadevan
Copy link
Member

@jobayle - I am not sure if the test that you added is running as a group but it may be running as a standalone test. You would need to create a test that extends test.SimpleBaseTest and within an @Test method you would need to create a suite object add the group filtering, instantiate the TestNG object and then run the tests with it.

@juherr
Copy link
Member

juherr commented Mar 10, 2019

@krmahadevan Do you confirm the issue?

@krmahadevan
Copy link
Member

@juherr I haven't got to this yet. I will get to this shortly. Since this is in the graph section, I would again need to brush up on its working :)

@jobayle
Copy link
Author

jobayle commented Mar 11, 2019

Thanks for the test case but it doesn't follow the current convention.

Where can I read about this convention?

I am not sure if the test that you added is running as a group but it may be running as a standalone test. You would need to create a test that extends test.SimpleBaseTest and within an @test method you would need to create a suite object add the group filtering, instantiate the TestNG object and then run the tests with it.

Me neither, also I tried to follow your instructions but eventually failed as I could not get it to work, sorry.

@juherr
Copy link
Member

juherr commented Mar 11, 2019

@jobayle You can check a recent package test like https://github.com/cbeust/testng/tree/master/src/test/java/test/name
You'll find a *Test which runs *Sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants